Document Falcon constant time errors.

open-quantum-safe · Sep 13, 2023 · 56881be · 56881be
1 parent 62e2ec6
commit 56881be
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 10 deletions.
diff --git a/docs/algorithms/sig/falcon.yml b/docs/algorithms/sig/falcon.yml
@@ -36,8 +36,8 @@ parameter-sets:
     supported-platforms: all
     common-crypto:
     - SHA3: liboqs
-    no-secret-dependent-branching-claimed: true
-    no-secret-dependent-branching-checked-by-valgrind: true
+    no-secret-dependent-branching-claimed: false
+    no-secret-dependent-branching-checked-by-valgrind: false
     large-stack-usage: false
   - upstream: primary-upstream
     upstream-id: avx2
@@ -47,8 +47,8 @@ parameter-sets:
       - avx2
     common-crypto:
     - SHA3: liboqs
-    no-secret-dependent-branching-claimed: true
-    no-secret-dependent-branching-checked-by-valgrind: true
+    no-secret-dependent-branching-claimed: false
+    no-secret-dependent-branching-checked-by-valgrind: false
     large-stack-usage: false
 - name: Falcon-1024
   claimed-nist-level: 5
@@ -63,8 +63,8 @@ parameter-sets:
     supported-platforms: all
     common-crypto:
     - SHA3: liboqs
-    no-secret-dependent-branching-claimed: true
-    no-secret-dependent-branching-checked-by-valgrind: true
+    no-secret-dependent-branching-claimed: false
+    no-secret-dependent-branching-checked-by-valgrind: false
     large-stack-usage: false
   - upstream: primary-upstream
     upstream-id: avx2
@@ -74,6 +74,6 @@ parameter-sets:
       - avx2
     common-crypto:
     - SHA3: liboqs
-    no-secret-dependent-branching-claimed: true
-    no-secret-dependent-branching-checked-by-valgrind: true
+    no-secret-dependent-branching-claimed: false
+    no-secret-dependent-branching-checked-by-valgrind: false
     large-stack-usage: false
diff --git a/tests/constant_time/sig/issues.json b/tests/constant_time/sig/issues.json
@@ -3,8 +3,8 @@
   "Dilithium2": [],
   "Dilithium3": [],
   "Dilithium5": [],
-  "Falcon-1024": [],
-  "Falcon-512": [],
+  "Falcon-1024": ["falcon"],
+  "Falcon-512": ["falcon"],
   "SPHINCS+-SHA256-128f-robust": ["sphincs"],
   "SPHINCS+-SHA256-128f-simple": ["sphincs"],
   "SPHINCS+-SHA256-128s-robust": ["sphincs"],

diff --git a/tests/constant_time/sig/issues/falcon b/tests/constant_time/sig/issues/falcon
@@ -0,0 +1,15 @@
+{
+   <insert_a_suppression_name_here>
+   Memcheck:Cond
+   src:sign.c:1226
+   # fun:PQCLEAN_FALCON*_AVX2_sampler
+   fun:ffSampling_fft_dyntree
+}
+
+{
+   <insert_a_suppression_name_here>
+   Memcheck:Cond
+   src:sign.c:1140
+   # fun:BerExp
+   fun:PQCLEAN_FALCON*_AVX2_sampler
+}