fix scan build warning

open-quantum-safe · Sep 7, 2023 · 2eaecae · 2eaecae
1 parent 7a639f5
commit 2eaecae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/sig_stfl/lms/sig_stfl_lms_functions.c b/src/sig_stfl/lms/sig_stfl_lms_functions.c
@@ -88,7 +88,7 @@ OQS_API OQS_STATUS OQS_SIG_STFL_lms_sigs_left(unsigned long long *remain, const
 	return OQS_SUCCESS;
 }
 
-OQS_API OQS_STATUS OQS_SIG_STFL_lms_sigs_total(uint64_t *total, const OQS_SIG_STFL_SECRET_KEY *secret_key) {
+OQS_API OQS_STATUS OQS_SIG_STFL_lms_sigs_total(unsigned long long *total, const OQS_SIG_STFL_SECRET_KEY *secret_key) {
 
 	if (total == NULL  || secret_key == NULL) {
 		return OQS_ERROR;
@@ -437,7 +437,7 @@ OQS_STATUS oqs_deserialize_lms_key(OQS_SIG_STFL_SECRET_KEY *sk, const size_t sk_
 		return OQS_ERROR;
 	}
 
-	if (sk->secret_key_data != NULL) {
+	if (sk->secret_key_data) {
 		//Key data already present
 		//We dont want to trample over data
 		return OQS_ERROR;

diff --git a/src/sig_stfl/xmss/sig_stfl_xmss_secret_key_functions.c b/src/sig_stfl/xmss/sig_stfl_xmss_secret_key_functions.c
@@ -30,12 +30,6 @@ OQS_STATUS OQS_SECRET_KEY_XMSS_deserialize_key(OQS_SIG_STFL_SECRET_KEY *sk, cons
 		return OQS_ERROR;
 	}
 
-	if (sk->secret_key_data != NULL) {
-		// Secret key data already present
-		// We don't want to trample over exist data
-		return OQS_ERROR;
-	}
-
 	memcpy(sk->secret_key_data, sk_buf, sk_len);
 
 	return OQS_SUCCESS;