scan-build fixes

open-quantum-safe · Jan 24, 2024 · 2957c3b · 2957c3b
1 parent 2c657b7
commit 2957c3b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/tests/vectors_kem.c b/tests/vectors_kem.c
@@ -21,15 +21,15 @@ typedef struct {
 fixed_prng_state prng_state = { .pos = 0 };
 
 /* Displays hexadecimal strings */
-void OQS_print_hex_string(const char *label, const uint8_t *str, size_t len) {
+static void OQS_print_hex_string(const char *label, const uint8_t *str, size_t len) {
 	printf("%-20s (%4zu bytes):  ", label, len);
 	for (size_t i = 0; i < (len); i++) {
 		printf("%02X", str[i]);
 	}
 	printf("\n");
 }
 
-void fprintBstr(FILE *fp, const char *S, const uint8_t *A, size_t L) {
+static void fprintBstr(FILE *fp, const char *S, const uint8_t *A, size_t L) {
 	size_t i;
 	fprintf(fp, "%s", S);
 	for (i = 0; i < L; i++) {
@@ -182,7 +182,6 @@ OQS_STATUS kem_vector(const char *method_name,
 	if (rv != 0) {
 		fprintf(stderr, "[vectors_kem] %s ERROR: shared secrets are not equal\n", method_name);
 		OQS_print_hex_string("ss_decaps", ss_decaps, kem->length_shared_secret);
-		OQS_print_hex_string("decaps_kprime", decaps_kprime, kem->length_shared_secret);
 		goto err;
 	}
 

diff --git a/tests/vectors_sig.c b/tests/vectors_sig.c
@@ -21,15 +21,15 @@ typedef struct {
 fixed_prng_state prng_state = { .pos = 0 };
 
 /* Displays hexadecimal strings */
-void OQS_print_hex_string(const char *label, const uint8_t *str, size_t len) {
+static void OQS_print_hex_string(const char *label, const uint8_t *str, size_t len) {
 	printf("%-20s (%4zu bytes):  ", label, len);
 	for (size_t i = 0; i < (len); i++) {
 		printf("%02X", str[i]);
 	}
 	printf("\n");
 }
 
-void fprintBstr(FILE *fp, const char *S, const uint8_t *A, size_t L) {
+static void fprintBstr(FILE *fp, const char *S, const uint8_t *A, size_t L) {
 	size_t i;
 	fprintf(fp, "%s", S);
 	for (i = 0; i < L; i++) {