Beautify code #97
Open
Beautify code #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew000
force-pushed
the
pull_request_1
branch
from
66a243d to
36be44b
Compare
Add typing Add pre-commit Reformat code Make code more secure Update workflow python_simplified.yml Update workflow python_detailed.yml Signed-off-by: andrew000 <[email protected]>
andrew000
force-pushed
the
pull_request_1
branch
from
36be44b to
e1a6fc7
Compare
andrew000
commented
Nov 14, 2024
oqs/oqs.py
Outdated
Comment on lines
356
to
363
| # TODO: What should it return? | ||
| # 1. tuple[bytes | int, bytes | int] | ||
| # 2. tuple[bytes, bytes | int] | ||
| # 3. tuple[bytes, bytes] | int | ||
| return ( | ||
| bytes(cast(bytes, ciphertext)), | ||
| bytes(cast(bytes, shared_secret)) if rv == OQS_SUCCESS else 0, | ||
| ) |
There was a problem hiding this comment.
What function should return?
Here function returns: tuple[bytes, bytes | int]
But I think developers may have made a mistake and wanted to return: tuple[bytes, bytes] | int
What can you say about this?
Salamist
reviewed
Dec 9, 2024
Bump deps Signed-off-by: andrew000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UV; https://docs.astral.sh/uvMyPyruffpre-commitruffos.path,os.system)python_simplified.ymlpython_detailed.ymlDrop workflow python version from 3.10 to 3.9 to be sure that the library will work on py3.9+. Also, I want to add
matrixto test the library on 3.9, 3.10, 3.11, 3.12, 3.13, but I don't see anything deprecated in 3.9 that can't be in 3.13 in this code.