OrbitControls -> MapControls #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also delete <React.StrictMode> in index.jsx? As far as I understand this is some debugging tool that somehow got into our website code 🙃 |
FlorianK13
approved these changes
Jan 17, 2025
|
My understanding is that when doing a release build, strict mode will not do anything, i.e. strict mode only has implications for local dev builds. But I'm happy to get rid of it, because it will fix the simulation running twice in parallel when testing the app locally 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404, switches OrbitControls for MapControls, and sets it up so that a single touch finger pans the map, while two finger touches rotate the map