Fix ocmb index value #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devenrao
approved these changes
Apr 5, 2024
devenrao
approved these changes
Apr 10, 2024
| @@ -672,7 +669,6 @@ enum pdbg_target_status pdbg_target_probe_ody_ocmb(struct pdbg_target *target) | |||
| fsi_target->status = PDBG_TARGET_NONEXISTENT; | |||
| return PDBG_TARGET_NONEXISTENT; | |||
| } | |||
There was a problem hiding this comment.
should not have removed these spaces
Use pdbg target index for ody targets
The ocmb index number is same as that of omi index number. There is no
mapping between inventory dimm index and the device tree index. Due to
this, it is difficult to find the failing ocmb index to collect the dumps.
To make it easier to identify the ocmb, updating the dev tree ocmb index
calculation to use the physical path number
The explorer chips use fapi position to identify the targets. The
odyssey chip uses target index with the recent change. Updating the code
to support the same.
Test results:
root@p10bmc:/tmp# ecmdquery chips
cage 0
node 0
slot 0
pu
p[0,1,2,3,4,5,6,7]
odyssey
p[62,2,6]
root@p10bmc:/tmp# getscom odyssey 08012400 -all
odyssey k0:n0:s0:p62 0x0008000000000000
odyssey k0:n0:s0:p02 0x0008000000000000
odyssey k0:n0:s0:p06 0x0008000000000000
/usr/bin/edbg getscom odyssey 08012400 -all
deepakala-k
force-pushed
the
fix_ocmb_index
branch
from
953a62e to
6fe93a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ocmb index value is currently the same as that of the OMI index. This number is not unique and it is not easy to map the index number with the inventory path of the dimm. So using the number at the end of the physical path as the index