POZ: To cater for additional requirements to parse SBE FFDC data #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swarnendu-R-C
suggested changes
Mar 26, 2024
deepakala-k
reviewed
Mar 26, 2024
devenrao
force-pushed
the
oper
branch
2 times, most recently
from
f386c5e to
297676e
Compare
devenrao
changed the title
dhruvibm
approved these changes
Apr 10, 2024
Swarnendu-R-C
approved these changes
Apr 10, 2024
To cater for new requirement where ffdc data is queried even after chip-op success, this is to fetch any traces or non critical sbe internal failures queued by SBE. modified ffdc method to not to dereference ffdc pointer if there is no data set rather simply return length as zero. caller upon receiving ffdc length as zero for success case will not create any PEL's Tested ENTER OPER: sbefifo_parse_output buflen 0x00004EE4 OPER: reply: cmd=0000aa01, len=20196, status=00000000 buflen=00004ee4, offset00004ee0 *out_len00004ed8 buflen=00004ee4, *out_len00004ed8 EXIT OPER: sbefifo_parse_output buflen 0x00004EE4 EXIT OPER: sbefifo_operation collectdump[1209]: Collect dump from (ocmb)(2) path(/tmp) id(1) type(1) clock(1) failingUnit(2) phosphor-log-manager[364]: SBE FFDC processing requested phosphor-log-manager[364]: SBE FFDC file fd:(8), parsing started phosphor-log-manager[364]: P0Z FFDC magic: 64429 length in words:151 Fapirc:33554433 phosphor-log-manager[364]: SBE FFDC: Internal FFDC packet phosphor-log-manager[364]: Created PEL 0x50005d00 (BMC ID 1356) with SRC BD20F401 Signed-off-by: Marri Devender Rao <[email protected]> Change-Id: I1ba80a35e174935560b9ba6232394cea2644b8d7
For POZ SBE can queue n number of FFDC packets till the maximum size is reached, modified to read upto 32KB of data. Change-Id: I3a73a605119968645e87154e91bfff0d3c4842d5 Signed-off-by: Marri Devender Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify sbe chip-op operation to read FFDC data for chip-op success case so as to get FFDC data from SBE for any earlier or internal SBE failure
As SBE now caters for multiple FFDC packets increase the size of the memory allocated by pdbg to read the FFDC data to 32KB.