Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for v5.0 release #471

Merged
merged 1 commit into from
Oct 26, 2023
Merged

update for v5.0 release #471

merged 1 commit into from
Oct 26, 2023

Conversation

janjust
Copy link
Contributor

@janjust janjust commented Oct 26, 2023

No description provided.

@janjust janjust requested review from jsquyres and awlauria October 26, 2023 15:13
@janjust
Copy link
Contributor Author

janjust commented Oct 26, 2023

note: we still have to edit the major changes.

nightly/index.php Show resolved Hide resolved
nightly/index.php Show resolved Hide resolved
software/ompi/v5.0/timeline-graph.php Outdated Show resolved Hide resolved
software/ompi/v5.0/version.inc Outdated Show resolved Hide resolved
@janjust
Copy link
Contributor Author

janjust commented Oct 26, 2023

We still have the major changes section to update, and I'll squash commits when ready

@janjust janjust added the ⚠️ WIP-DNM! Work in Progress. Do NOT Merge! label Oct 26, 2023
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and squash.

@janjust
Copy link
Contributor Author

janjust commented Oct 26, 2023

@jsquyres @awlauria I changed the major-changes section for v5.0.0, considering we have a lot of smaller changes I decided to leave those out and only point out a few notable ones. If you think I need to add more, please point them out and I'll add them.

software/ompi/major-changes.php Show resolved Hide resolved

<p></p>

<li> Open MPI v5.0.x is ABI compatible with Open MPI 4.1.x.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and 4.0.x.


</ol></p>

For the full list of features and updates please refer to the v5.0.x news section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably link to this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, why don't I remove all the features, and link to v5.0 docs, and only leave building/linking, prrte, and ABI compatilibity changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's 3 options

  1. Keep what is here, fix the comments I made.
  2. Do the entire cleanup (i.e., put in the redirect for major-changes.php to somewhere in the docs),
  3. Keep the major-changes.php page, but link the v5.0 stuff to the appropriate places in the RST docs.

You pick which one you want to do right now. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done - fixed the comments, linked to v5.0 news for other features.

Signed-off-by: Tomislav Janjusic <[email protected]>
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash before merging.

@janjust
Copy link
Contributor Author

janjust commented Oct 26, 2023

done

@janjust janjust merged commit 2850aa2 into open-mpi:master Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ WIP-DNM! Work in Progress. Do NOT Merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants