-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for v5.0 release #471
Conversation
note: we still have to edit the major changes. |
We still have the major changes section to update, and I'll squash commits when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and squash.
software/ompi/major-changes.php
Outdated
|
||
<p></p> | ||
|
||
<li> Open MPI v5.0.x is ABI compatible with Open MPI 4.1.x.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and 4.0.x.
software/ompi/major-changes.php
Outdated
|
||
</ol></p> | ||
|
||
For the full list of features and updates please refer to the v5.0.x news section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably link to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous comment, why don't I remove all the features, and link to v5.0 docs, and only leave building/linking, prrte, and ABI compatilibity changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's 3 options
- Keep what is here, fix the comments I made.
- Do the entire cleanup (i.e., put in the redirect for
major-changes.php
to somewhere in the docs), - Keep the
major-changes.php
page, but link the v5.0 stuff to the appropriate places in the RST docs.
You pick which one you want to do right now. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done - fixed the comments, linked to v5.0 news for other features.
Signed-off-by: Tomislav Janjusic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash before merging.
done |
No description provided.