Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1400 Ventilation template update #1401

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Issue1400 Ventilation template update #1401

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39886e7
m_flow_nominal calculation, dp_nominal_sup and ret
annadellisola Dec 17, 2024
9e6326a
nominal dp to 0
annadellisola Dec 19, 2024
207daf0
Update n in the example such that it represents an air change rate pe…
jelgerjansen Dec 19, 2024
11fe14e
Fix typo multiplication
jelgerjansen Dec 19, 2024
3443e3f
Fix reference to nZones
jelgerjansen Dec 19, 2024
7d69824
remove duplicate nZones parameter
lucasverleyen Dec 23, 2024
e5f8ae5
removed constrainedby nZones
annadellisola Dec 24, 2024
b1132fb
revert removal of nZones in constrainedby
lucasverleyen Dec 24, 2024
867202f
replace 3 by structure dependent value
lucasverleyen Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions IDEAS/Templates/Examples/ConstantAirFlowRecup.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ model ConstantAirFlowRecup
IDEAS.Templates.Structure.ThreeZone structure(
redeclare package Medium = Medium)
annotation (Placement(transformation(extent={{-80,-40},{-50,-20}})));
replaceable IDEAS.Templates.Ventilation.ConstantAirFlowRecup constantAirFlowRecup(
n=2.*structure.VZones)
replaceable IDEAS.Templates.Ventilation.ConstantAirFlowRecup constantAirFlowRecup(nZones=structure.nZones, n=2.*ones(structure.nZones))
constrainedby IDEAS.Templates.Interfaces.BaseClasses.VentilationSystem(
nZones=3,
lucasverleyen marked this conversation as resolved.
Show resolved Hide resolved
VZones=structure.VZones,
Expand Down
17 changes: 13 additions & 4 deletions IDEAS/Templates/Ventilation/ConstantAirFlowRecup.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ model ConstantAirFlowRecup

parameter Real[nZones] n
"Air change rate (Air changes per hour ACH)";
final parameter Modelica.Units.SI.MassFlowRate m_flow_nominal=sum(n)/3600*
final parameter Modelica.Units.SI.MassFlowRate m_flow_nominal=sum(n .* VZones)/3600*
1.204 "total ventilation mass flow rate";
parameter Modelica.Units.SI.Time tau=30
"time constant of the ventilation system";
Expand All @@ -26,11 +26,15 @@ model ConstantAirFlowRecup
min=0,
max=1) = 0.80 "Motor efficiency";

parameter Modelica.Units.SI.Pressure dp_nominal_sup=0
"Nominal pressure drop in the heat exchanger at the supply side";
parameter Modelica.Units.SI.Pressure dp_nominal_ret=0
"Nominal pressure drop in the heat exchanger at the return side";
IDEAS.Fluid.HeatExchangers.ConstantEffectiveness hex(
m1_flow_nominal=m_flow_nominal,
m2_flow_nominal=m_flow_nominal,
dp1_nominal=0,
dp2_nominal=0,
dp1_nominal=dp_nominal_ret,
dp2_nominal=dp_nominal_sup,
redeclare package Medium1 = Medium,
redeclare package Medium2 = Medium,
eps=recupEff) "Heat exchanger for the recuperator"
Expand All @@ -46,7 +50,7 @@ model ConstantAirFlowRecup
annotation (Placement(transformation(extent={{-80,-30},{-100,-10}})));
IDEAS.Fluid.Movers.FlowControlled_m_flow fan[nZones](
each use_riseTime=false,
m_flow_nominal=n ./ 3600.*1.204,
m_flow_nominal=n .* VZones ./ 3600.*1.204,
redeclare each package Medium = Medium,
each energyDynamics=Modelica.Fluid.Types.Dynamics.SteadyState,
each inputType=IDEAS.Fluid.Types.InputType.Constant)
Expand Down Expand Up @@ -94,6 +98,11 @@ equation
Documentation(revisions="<html>
<ul>
<li>
December 17, 2024, by Anna Dell'Isola:<br/>
Update calculation of ventilation mass flow rate and addition of nominal pressure drops in heat exchanger.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1400\">#1400</a>
</li>
<li>
October 30, 2024, by Lucas Verleyen:<br/>
Updates according to <a href=\"https://github.com/ibpsa/modelica-ibpsa/tree/8ed71caee72b911a1d9b5a76e6cb7ed809875e1e\">IBPSA</a>.<br/>
See <a href=\"https://github.com/open-ideas/IDEAS/pull/1383\">#1383</a>
Expand Down