Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates to Provider module in preparation for InMemoryProvider #99

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

maxveldink
Copy link
Member

@maxveldink maxveldink commented Feb 16, 2024

This PR

  • Fixes two bugs I encountered during local development (bin/console not loading and a memorization issue with Configuration
  • Adds constants for Reason and ErrorCode enumerations
  • Refactored ResolutionDetails up a module layer, and updated the client to return an EvaluationDetails struct, matching a callout from a spec:

The resolution details structure is not exposed to the Application Author. It defines the data which Provider Authors must return when resolving the value of flags.

(Note at the bottom of this section)

Follow-up Tasks

  • Following this PR, I will PR the InMemoryProvider that I've been working on to satisfy a utility in Appendix A.

We provide memoization for this but were bypassing that and forwarding to the ivar itself.

Signed-off-by: Max VelDink <[email protected]>
@maxveldink maxveldink requested a review from a team as a code owner February 16, 2024 21:44
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bfe176) 98.90% compared to head (960d486) 99.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   98.90%   99.22%   +0.32%     
==========================================
  Files           6       11       +5     
  Lines          91      129      +38     
==========================================
+ Hits           90      128      +38     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxveldink maxveldink changed the title Maxveldink/updates to evaluation feat: Updates to Provider module in preparation for InMemoryProvider Feb 16, 2024
@maxveldink
Copy link
Member Author

@beeme1mr @toddbaert Before I merge in some of these PRs, I want to double-check if I need a maintainer review first or if, at the approver level, I can also merge in PRs.

@beeme1mr
Copy link
Member

You should be able to merge whenever you're ready. Let me know if you're unable to and we'll update your permissions.

@maxveldink maxveldink merged commit 2d89570 into main Feb 21, 2024
17 checks passed
@maxveldink maxveldink deleted the maxveldink/updates-to-evaluation branch February 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants