-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updates to Provider
module in preparation for InMemoryProvider
#99
Conversation
…dule Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
We provide memoization for this but were bypassing that and forwarding to the ivar itself. Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 98.90% 99.22% +0.32%
==========================================
Files 6 11 +5
Lines 91 129 +38
==========================================
+ Hits 90 128 +38
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Provider
module in preparation for InMemoryProvider
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
@beeme1mr @toddbaert Before I merge in some of these PRs, I want to double-check if I need a maintainer review first or if, at the approver level, I can also merge in PRs. |
You should be able to merge whenever you're ready. Let me know if you're unable to and we'll update your permissions. |
This PR
bin/console
not loading and a memorization issue withConfiguration
Reason
andErrorCode
enumerationsResolutionDetails
up a module layer, and updated the client to return anEvaluationDetails
struct, matching a callout from a spec:(Note at the bottom of this section)
Follow-up Tasks
InMemoryProvider
that I've been working on to satisfy a utility in Appendix A.