-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds InMemoryProvider
#102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 99.25% 99.39% +0.13%
==========================================
Files 11 12 +1
Lines 134 164 +30
==========================================
+ Hits 133 163 +30
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Max VelDink <[email protected]>
beeme1mr
approved these changes
Feb 28, 2024
@open-feature/sdk-ruby-maintainers Going to merge this in tomorrow morning if there are no issues with it |
josecolella
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
InMemoryProvider
that can be used for initializing with flags in process, as defined in Appendix A.debug
gem for development and testingHow to test
You can instantiate and use an InMemoryProvider in an OF project and see that flags can be set through it.