Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds InMemoryProvider #102

Merged
merged 7 commits into from
Mar 6, 2024
Merged

feat: adds InMemoryProvider #102

merged 7 commits into from
Mar 6, 2024

Conversation

maxveldink
Copy link
Member

This PR

  • Adds InMemoryProvider that can be used for initializing with flags in process, as defined in Appendix A.
  • Adds debug gem for development and testing
  • Enables the RSpec focus feature

How to test

You can instantiate and use an InMemoryProvider in an OF project and see that flags can be set through it.

@maxveldink maxveldink requested a review from a team as a code owner February 28, 2024 18:37
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (db48cd5) to head (e92912c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   99.25%   99.39%   +0.13%     
==========================================
  Files          11       12       +1     
  Lines         134      164      +30     
==========================================
+ Hits          133      163      +30     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxveldink
Copy link
Member Author

@open-feature/sdk-ruby-maintainers Going to merge this in tomorrow morning if there are no issues with it

@maxveldink maxveldink merged commit 25680a4 into main Mar 6, 2024
17 checks passed
@maxveldink maxveldink deleted the mv/in-memory-provider branch March 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants