fix: onContextChanged not running for named providers #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reining <[email protected]>
|
The onContextChanged is now called for all providers. I think what we still have to do is check the numbering of all tests as we mostly used requirement names for the describe blocks, and the number shifted a bit. |
beeme1mr
reviewed
Jul 21, 2023
|
I've created an issue to update the review and update test names to match the updated spec. |
beeme1mr
approved these changes
Jul 23, 2023
|
@lukas-reining I'm not sure this is a feat, I think it was more of a fix. I'd recommend Though TBH, we should probably publish our first non-experimental soon. |
beeme1mr
changed the title
beeme1mr
pushed a commit
that referenced
this pull request
Jul 24, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.8-experimental](web-sdk-v0.3.7-experimental...web-sdk-v0.3.8-experimental) (2023-07-24) ### Features * typesafe event emitter ([#490](#490)) ([92e3a72](92e3a72)) ### Bug Fixes * onContextChanged not running for named providers ([#491](#491)) ([1ab0cc6](1ab0cc6)) * race adding handler during init ([#501](#501)) ([0be9c5d](0be9c5d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes context propagation for the static-context-paradigm as found in #488.
Related Issues
Fixes #488
Notes
Follow-up Tasks
How to test