PR review suggestions #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of reproducing feature logic in the tests
ensures that untagged elements and their children are included in results
pomegranited
force-pushed
the
jill/rpenido/fal-3610-download-course-tag-spreadsheet
branch
from
a86cfa2 to
1e13f54
Compare
|
Hi @pomegranited! Question: I need to have a mongo instance running to run the tests that use the module store. Is it the same for you? DJANGO_SETTINGS_MODULE=cms.envs.test pytest openedx/core/djangoapps/content_tagging/ |
rpenido
merged commit 1e13f54
into
rpenido/fal-3610-download-course-tag-spreadsheet
44 of 45 checks passed
rpenido
deleted the
jill/rpenido/fal-3610-download-course-tag-spreadsheet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting my suggestions as a PR to ensure legibility and discussions.