feat(keystone): DOMA-10642 custom field for encrypted text #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YEgorLu
added
✋🙂 Review please
dkoviazin
reviewed
Nov 11, 2024
packages/keystone/fields/SymmetricEncryptedText/Implementation.js
Outdated
Show resolved
Hide resolved
pahaz
reviewed
Nov 11, 2024
pahaz
reviewed
Nov 11, 2024
packages/keystone/fields/SymmetricEncryptedText/Implementation.js
Outdated
Show resolved
Hide resolved
pahaz
reviewed
Nov 12, 2024
pahaz
reviewed
Nov 12, 2024
pahaz
reviewed
Nov 22, 2024
pahaz
reviewed
Nov 23, 2024
pahaz
reviewed
Nov 23, 2024
pahaz
reviewed
Nov 23, 2024
pahaz
reviewed
Nov 23, 2024
packages/keystone/fields/SymmetricEncryptedText/utils/decryptInfo.js
Outdated
Show resolved
Hide resolved
pahaz
reviewed
Nov 23, 2024
packages/keystone/fields/SymmetricEncryptedText/utils/decryptInfo.js
Outdated
Show resolved
Hide resolved
pahaz
reviewed
Nov 24, 2024
pahaz
reviewed
Nov 24, 2024
Comment on lines
+42
to
+45
| const errorStart = _getErrorStart(listKey, path) | ||
| const encryptionManager = _getEncryptionManager(errorStart, options) | ||
| set(options, 'encryptionManager', encryptionManager) |
There was a problem hiding this comment.
it's hard to understand whats going on here
There was a problem hiding this comment.
just need to provide EncryptionManager for fieldAdapter. FieldAdapter parses options before we can do something in constructor here, so must update "options" before super()
pahaz
reviewed
Nov 25, 2024
pahaz
reviewed
Nov 25, 2024
pahaz
reviewed
Nov 25, 2024
pahaz
reviewed
Nov 25, 2024
pahaz
reviewed
Nov 25, 2024
pahaz
reviewed
Nov 25, 2024
pahaz
approved these changes
Nov 25, 2024
…ypted by manager; Do not encrypt field before database, if it is encrypted; Enhance script; Rename field;
YEgorLu
force-pushed
the
feat/keystone/DOMA-10642/encrypted-field-type
branch
from
c342ded
to
bdb5cdd
Compare
dkoviazin
approved these changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify work with encrypted data, remove 'keyField's, support different algorithms and secrets on same table
See README.md