Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global): INFRA-648 strict linter for changed files #5422

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SavelevMatthew
Copy link
Member

@SavelevMatthew SavelevMatthew commented Nov 4, 2024

TODO:

  • Figure out how to get changed files inside submodules, and not submodules itself like app/registry/file.ts instead of app/registry
  • Change CI file
  • Test on pull_request action type
  • Remove tmp files to test CI
  • switch back PR trigger

message: 'Please use `import [package] from \'lodash/[package]\'` instead',
},
{
group: ['*clientSchema*'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have other utils in clientSchema, for example convertEmployeesToOptions in BaseTicketForm. Is this affect it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so, I have not figured out the way to fix it. The easy way is to move it to other file, for example:
domains/x/utils/table.ts or domains/x/utils/render.ts or something like that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this utils should be placed in clientSchema. Since schema initially told us its the way to receive data on client

Copy link

sonarcloud bot commented Nov 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants