-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global): INFRA-648 strict linter for changed files #5422
base: main
Are you sure you want to change the base?
Conversation
a2ae32d
to
4453a18
Compare
message: 'Please use `import [package] from \'lodash/[package]\'` instead', | ||
}, | ||
{ | ||
group: ['*clientSchema*'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have other utils in clientSchema
, for example convertEmployeesToOptions
in BaseTicketForm
. Is this affect it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess so, I have not figured out the way to fix it. The easy way is to move it to other file, for example:
domains/x/utils/table.ts
or domains/x/utils/render.ts
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this utils should be placed in clientSchema. Since schema
initially told us its the way to receive data on client
ee697f9
to
8014b3e
Compare
Quality Gate passedIssues Measures |
TODO:
app/registry/file.ts
instead ofapp/registry