-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proof of work] feat(keystone): change graphql-playground to GraphiQL #5386
base: main
Are you sure you want to change the base?
Conversation
Quality Gate failedFailed conditions |
new GraphQLApp({ | ||
apollo: { | ||
formatError: safeApolloErrorFormatter, | ||
debug: IS_ENABLE_APOLLO_DEBUG, | ||
introspection: IS_ENABLE_DANGEROUS_GRAPHQL_PLAYGROUND, | ||
playground: IS_ENABLE_DANGEROUS_GRAPHQL_PLAYGROUND, | ||
playground: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure but playground: false might be default
<head> | ||
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Playground - __REPLACE_TO_YOUR_SERVER_URL__</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<title>Playground - __REPLACE_TO_YOUR_SERVER_URL__</title> | |
<title>Playground</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even condo playground)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point here is to be able to differentiate between sandbox tabs of different applications.
This is exactly how it works for us now.
However, we can forget about this moment)
<script crossorigin src="https://unpkg.com/react-dom/umd/react-dom.production.min.js"></script> | ||
<script crossorigin src="https://unpkg.com/graphiql/graphiql.min.js"></script> | ||
<script> | ||
const apiPath = '__REPLACE_TO_YOUR_API_PATH__' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not looking good)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I found the reason below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to add a library for generating templates, but we already use nunjucks
- I'll try it
headers: { | ||
'Content-Type': 'application/json', | ||
}, | ||
credentials: 'omit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment we con setup this during front-end. Our partners can use their own tokens
async prepareMiddleware () { | ||
// nosemrep: javascript.express.security.audit.express-check-csurf-middleware-usage.express-check-csurf-middleware-usage | ||
const app = express() | ||
app.get(this._graphiqlPath, (req, res) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be we need to move it to another URL?
No description provided.