Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(condo): DOMA-8764 allow notify period end be smaller than start #5128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(condo): DOMA-8764 allow notify period end be smaller than start #5128

wants to merge 2 commits into from

Conversation

abshnko
Copy link
Member

@abshnko abshnko commented Aug 21, 2024

removed check that start notify period date must be smaller than end date (for MeterReportingPeriod)

telegram-cloud-photo-size-2-5346327466056211728-y

@abshnko abshnko added the 👶 small Easy to review changes up to 50 lines of code label Aug 21, 2024
@abshnko abshnko force-pushed the fix/condo/DOMA-8764/allow-notify-period-end-be-smaller branch from b262f5f to 2dec7b6 Compare August 23, 2024 10:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@abshnko abshnko force-pushed the fix/condo/DOMA-8764/allow-notify-period-end-be-smaller branch from 2dec7b6 to 3fc2b49 Compare November 11, 2024 11:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VKislov VKislov VKislov approved these changes

@Alllex202 Alllex202 Alllex202 approved these changes

@AleX83Xpert AleX83Xpert AleX83Xpert approved these changes

@dkoviazin dkoviazin dkoviazin approved these changes

Assignees
No one assigned
Labels
👶 small Easy to review changes up to 50 lines of code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abshnko @dkoviazin @AleX83Xpert @Alllex202 @VKislov