DOMA-8614 News Item Sharing getRecipients proxy function #4374
Conversation
toplenboren
added
🔬 WIP
toplenboren
removed
🔬 WIP
toplenboren
force-pushed
the
toplenboren-7397
branch
from
78ce404
to
a19b2f5
Compare
toplenboren
changed the title
| }, | ||
| { | ||
| access: true, | ||
| type: 'type GetNewsSharingRecipientsOutput { id: String!, name: String!, recipients: Int }', |
There was a problem hiding this comment.
recipients must be a number or an object. If it is a number, then we can call it resipientsCount
There was a problem hiding this comment.
Thanks, will change to recipientsCount (this reallly is just the number of subscribers :-) )
apps/condo/domains/news/schema/GetNewsSharingRecipientsService.test.js
Outdated
Show resolved
Hide resolved
| const organizationId = get(b2bContext, 'organization', null) | ||
| if (!organizationId) { return false } | ||
|
|
||
| return await checkPermissionInUserOrganizationOrRelatedOrganization(user.id, organizationId, 'canReadNewsItems') |
There was a problem hiding this comment.
It was made intentionally. If you can read and manage newsItems, then you can send news to telegram and other services
There was a problem hiding this comment.
...you can read and manage newsItems, then you can send news to telegram and other services
What about to check canManage permission?
There was a problem hiding this comment.
will double check it
There was a problem hiding this comment.
Got it, changed permission to canManageNewsItems. Thanks!
fix(condo) DOMA-7397 finish GetNewsSharingRecipientsService code fix(condo) DOMA-7397 learn how to launch query fix(condo) DOMA-7397 add example api fix(condo) DOMA-7397 add TESTS_FAKE_CLIENT_EXPRESS_PORT variable fix(condo) DOMA-7397 add new error fix(condo) DOMA-7397 fix more tests fix(condo) DOMA-7397 figure out translations fix(condo) DOMA-7397 figure out graphql types fix(condo) DOMA-7397 figure out tests fix(condo) DOMA-7397 maketypes
…d introduce a set of functions in test.utils.js
toplenboren
force-pushed
the
toplenboren-7397
branch
from
604380f
to
10e50ff
Compare
|
So, we need a small proxy function to call News Sharing Miniapp's getRecipients function