chore(condo): DOMA-8419 stop comparing addresses (#4379)

Also, improved logs for address service plugin
open-condo-software · Feb 12, 2024 · 14233ae · 14233ae
1 parent d18e304
commit 14233ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/apps/condo/domains/property/hooks/useImporterFunctions.tsx b/apps/condo/domains/property/hooks/useImporterFunctions.tsx
@@ -81,8 +81,7 @@ export const useImporterFunctions = (): [Columns, RowNormalizer, RowValidator, O
         const [address] = row
         const suggestions = await addressApi.getSuggestions(String(address.value))
 
-        let suggestion = get(suggestions, ['suggestions', 0], null)
-        if (get(suggestion, 'value') !== get(address, 'value')) suggestion = null
+        const suggestion = get(suggestions, ['suggestions', 0], null)
 
         const suggestionType = get(suggestion, 'type')
         const houseTypeFull = get(suggestion, ['data', 'house_type_full'])

diff --git a/packages/keystone/plugins/addressService.js b/packages/keystone/plugins/addressService.js
@@ -143,16 +143,16 @@ const addressService = ({
                 addressFields['addressKey'] = get(result, 'addressKey')
                 addressFields['addressSources'] = get(result, 'addressSources', [])
             } else {
-                const msg = `No address found by string "${addressToSearch}"`
                 logger.error({
-                    msg,
+                    msg: 'No address found by string',
+                    addressToSearch,
                     operation,
                     listKey,
                     itemId: get(existingItem, 'id'),
                     addressKey: get(existingItem, 'addressKey'),
                 })
 
-                throw new Error(msg)
+                throw new Error(`No address found by string "${addressToSearch}"`)
             }
         } else {
             // NOTE(pahaz): if you don't need to change the address you want to prevent any changes