Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove api_keys fields until backend is released #7336

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

hpeebles
Copy link
Collaborator

No description provided.

Copy link

canbench 🏋 (dir: .)

./canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: push_simple_text_messages
  total:
    instructions: 223.47 M (-0.20%) (change within noise threshold)
    heap_increase: 12 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: add_reactions
  total:
    instructions: 891.68 M (-1.27%) (change within noise threshold)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@hpeebles hpeebles enabled auto-merge (squash) January 31, 2025 13:05
Copy link
Contributor

@ivan-jukic ivan-jukic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally, I'd just leave a TODO explaining when to uncomment that code.

@hpeebles hpeebles merged commit caa3e3f into master Jan 31, 2025
7 checks passed
@hpeebles hpeebles deleted the api_keys branch January 31, 2025 13:13
@hpeebles
Copy link
Collaborator Author

Optionally, I'd just leave a TODO explaining when to uncomment that code.

Yeah true, but I think we're fine in this case because I'd imagine we release the website then immediately revert this PR, we can then release the backend changes next week and can continue dev'ing bots locally without having to use a forked version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants