Extract data for writs of possession case events #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasThoren
commented
Jul 2, 2020
| (6, "Ant, Ten", "01/02/2020"), | ||
| # (7, "Ant, Ten", "01/08/2020"), |
There was a problem hiding this comment.
Not sure what the expected dates should be here. In case J2-CV-20-000021 (example_7.html), there are two case events that have "Served" dates: the "Service" case event and the "Writ" case event. The logic in hearing.py's was_defendant_served method uses the most-recent "Served" date found, which in this case is for the "Writ" event. Is that correct? Or should was_defendant_served always return the "Service" event's date?
There was a problem hiding this comment.
I think it should target "Service" case events specifically. They both have RCDSE# headers, but I think that ideally we treat them separate from one another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7.
This adds functionality to extract details from case events relating to writs of possession.
The main case event seems to be the "Writ" event, since that includes information such as the the served date, returned date, and who the writ was served to.
The two example cases show there can also be "Writ of Possession Service", "Writ of Possession Requested", "Writ Returned to Court", and "Writ of Possession Sent to Constable's Office" case events. Those case events only have dates in the example cases, but I gave each of them their own methods in the event that some cases have additional information for those event types.
Please let me know what you think!