Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

was_defendant_served method should only check "Service" case events #30

Open
ThomasThoren opened this issue Jul 4, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@ThomasThoren
Copy link
Collaborator

The was_defendant_served method checks for "Served" dates across all case event types. It should only check for the "Service" case event.

For example, case J2-CV-20-000021 has two events with "Served" dates: "Writ" and "Service". The was_defendant_served method would return the "Served" date of the "Writ" event instead of the "Service" event.

Also, the was_defendant_served method is only used in the test suite. Is the method needed any longer?

@mscarey
Copy link
Collaborator

mscarey commented Jul 4, 2020

I think the was_defendant_served method is still needed because service of process was issue #6. It's possible the method only ever needed to return a boolean rather than a date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants