Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added information regarding K&s install customization #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpiaseck
Copy link
Contributor

Kubespray offers K&s cluster customization which needs to be desribed. Default use of instruction leads to failure during TASK [kubernetes/control-plane : Kubeadm | Initialize first master] which is caused by using port 6443 instead 8080.

Kubespray offers K&s cluster customization which needs to be desribed.
Default use of instruction leads to failure during  TASK [kubernetes/control-plane : Kubeadm | Initialize first master] which is caused by using port 6443 instead 8080.
@mkbhanda
Copy link
Collaborator

@jpiaseck please address the DCO issue and minor merge conflict.

@dbkinder
Copy link
Contributor

@jpiaseck please address the DCO issue and minor merge conflict.

BTW, when you use the online github.com editor, you need to manually add the Signed-off-by: line to the commit message (normally added with you use "git commit -s")

- container manager
- kube_apiserver_port
- kube_pods_subnet
- all K&s addons configurations, or even define to deploy cluster on hyperscaller like AWS or GCP.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not Kubernetes expertise, but the "K&s" looks like a typo for me here. you meant k8s? the line 93 and 95 have same issues here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkbhanda , what do you mean by DCO issue?
@ftian1 you are right , K&s seems like a typo.

Copy link
Collaborator

@mkbhanda mkbhanda Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO -- https://github.com/apps/dco
Basically, in your comment messages need a -s with your email matching up with your github ID.
"git commit -a -s -m "something"
You could also configure this in your .gitconfig

Then when you do git log in a repo you get information about who made the commit. eg: Signed-off-by: letonghan [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants