Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamoDB permissions #22

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: dynamoDB permissions #22

merged 1 commit into from
Mar 14, 2024

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Mar 14, 2024

Closes #21
This diff extends the dynamoDB permissions for the oonidevops-github-policy.

Copy link

Terraform Run Output 🤖

Format and Style 🖌success

Initialization ⚙️success

Validation 🤖success

Validation Output

$ terraform validate
Success! The configuration is valid.

Plan 📖success

  • undefined
Show Plan

$ terraform plan
Acquiring state lock. This may take a few moments...
Pusher @DecFox
Action pull_request
Environment dev
Workflow .github/workflows/check_terraform.yml
Last updated Thu, 14 Mar 2024 17:53:24 GMT

Copy link

Ansible Run Output 🤖

Ansible Playbook Recap 🔍



Ansible playbook output 📖success

Show Execution

$ ansible-playbook playbook.yml --check --diff -i ../tf/modules/ansible_inventory/inventories/inventory-dev.ini
[WARNING]: provided hosts list is empty, only localhost is available. Note that
the implicit localhost does not match 'all'
[WARNING]: Could not match supplied host pattern, ignoring: clickhouse_servers

PLAY [ClickHouse servers] ******************************************************
skipping: no hosts matched

PLAY RECAP *********************************************************************

Pusher @DecFox
Action pull_request
Working Directory
Workflow .github/workflows/check_ansible.yml
Last updated Thu, 14 Mar 2024 17:53:56 GMT

@hellais
Copy link
Member

hellais commented Mar 14, 2024

If we want to allow all permissions on dynamodb, should we then perhaps scope the permissions to arn:aws:dynamodb:eu-central-1:905418398257:table/oonidevops-dev-terraform-state-lock, where 905418398257 is ooni_dev_org_id, so that if we end up using dynamodb for something else that isn't the terraform state lock we aren't giving full permissions to github?

@hellais hellais merged commit 3e2c2f4 into main Mar 14, 2024
2 checks passed
@hellais hellais deleted the issue/21 branch March 14, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tighten up oonidevops_github policy
2 participants