Parquet/no-build-tool java profile usability improvements #1906
msbarrysonar.yml
on: pull_request
Analyze with Sonar
5m 24s
Annotations
5 warnings
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/Planetiler.java#L826
Extract this nested try block into a separate method.
rule: java:S1141 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1141&rule_key=java%3AS1141)
issue url: https://sonarcloud.io/project/issues?pullRequest=914&open=AZAHHLOAdf33a-ehTcUh&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/expression/Expression.java#L189
Either remove or fill this block of code.
rule: java:S108 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS108&rule_key=java%3AS108)
issue url: https://sonarcloud.io/project/issues?pullRequest=914&open=AZAHHLMydf33a-ehTcUg&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/validator/BaseSchemaValidator.java#L219
Remove this unused method parameter "allowExtra".
rule: java:S1172 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1172&rule_key=java%3AS1172)
issue url: https://sonarcloud.io/project/issues?pullRequest=914&open=AZAHHLOXdf33a-ehTcUj&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/test/java/com/onthegomap/planetiler/PlanetilerTests.java#L2362
Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body.
rule: java:S1130 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1130&rule_key=java%3AS1130)
issue url: https://sonarcloud.io/project/issues?pullRequest=914&open=AZAHHLP0df33a-ehTcUl&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/test/java/com/onthegomap/planetiler/validator/BaseSchemaValidatorTest.java#L95
Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body.
rule: java:S1130 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1130&rule_key=java%3AS1130)
issue url: https://sonarcloud.io/project/issues?pullRequest=914&open=AZAHHLPEdf33a-ehTcUk&id=onthegomap_planetiler
|