fix running precompiled tests via ginkgo CLI on windows (#529) #531
Conversation
|
Change mostly makes sense to me. I wonder if we should start running CI against windows now (https://blog.travis-ci.com/2018-10-11-windows-early-release), I'd like to get some coverage if we are going to be supporting other environments like this. |
| var packageName string | ||
| if strings.HasSuffix(path, ".test.exe") { | ||
| packageName = strings.TrimSuffix(filepath.Base(path), ".test.exe") | ||
| } else { |
There was a problem hiding this comment.
Can we move assign value in else block to packageName declaration?
|
One thing that could be improved is to use Go standard library functions that automatically append |
|
Checking on the status of this. Happy to help if needed. I had originally thought that just getting rid of the exe suffix would have been sufficient but was surprised in my testing to find thats not the case. |
|
sorry y'all i haven't paid enough attention to this issue @johnSchnake can you confirm that this change fixes support for precompiled tests on windows? or are you saying they it doesn't? i don't have access to a windows box to test it on myself... |
|
Sure thing. I just tried it out and was hacking a bit but when I rebased this onto master, put the exe extension back on my the tests, and ran on an azure k8s cluster I could see tests starting. prior to all that jazz the master branch would just report no suites found. A rebase may be all this needs unless you know of other shortcomings I hadn’t seen. |
Hello,
Here is a suggested change to support running precompiled tests on windows via ginkgo CLI (see issue #529 for more details).