basic url hash functionality to make examples linkable #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is an attempt to do onlywei#30
| if (example) { | ||
| explainGit.reset(); | ||
| document.getElementById(linkId).classList.add('selected'); | ||
| explainGit.open(Object.create(example)); |
There was a problem hiding this comment.
Nice, I certainly don't care about IE8 at all! Although this should probably be done in the explainGit.open() method instead of here.
|
I'm going to fix these issues you mentioned in this pull request. |
moving Object.create into .open()
| open = function (args) { | ||
| var name = prefix + args.name, | ||
| open = function (_args) { | ||
| var args = Object.create(_args), |
There was a problem hiding this comment.
Moved Object.create() into explainGit.open().
Renaming the parameter was harder to screw up then changing all internal references.
onlywei
added a commit
that referenced
this pull request
Jan 28, 2015
basic url hash functionality to make examples linkable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to do #30 .
Functionality is preserved. Back button works as expected.
I had to do an unlucky hack because args.name is modified in every call, so I had to copy the whole argument object before feeding it to open.
I did it with
Object.create(), which is ES5 standard and solves this with simple prototype inheritance.Every non-crappy browser supports it, but if IE8 support is necessary, I might need to change it.