Update expected_win_probability to match math in glicko_update
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `expected_win_probability` to Glicko-2 math, as if it were extracted from `glicko_update`. This is based on the assumption that the `E` in `Glicko-2` still means "expected win probability". Previously this function was using the math from Glicko-1.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
expected_win_probabilityto Glicko-2 math, as if it were extracted fromglicko_update. This is based on the assumption that theEinGlicko-2still means "expected win probability".Previously this function was using the math from Glicko-1.
Relates to #45.
Replaces #54. Note: the math domain error I thought #54 would fix does not go away with this commit. That has been fixed directly via #57.