Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Update model Block REST API Response #1539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Jan 13, 2025

issue: onflow/flow-go#6874

Context

In this PR the openAPI was updated:

  • the omitempty tag was added to the Expandable field for Block,
  • the block_status field was added for Block

@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Jan 13, 2025
@UlyanaAndrukhiv UlyanaAndrukhiv marked this pull request as ready for review January 14, 2025 09:36
@@ -955,6 +955,8 @@ components:
format: uri
_links:
$ref: '#/components/schemas/Links'
block_status:
Copy link
Contributor Author

@UlyanaAndrukhiv UlyanaAndrukhiv Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block_status field was introduced in flow-go's model_block.go but was missing here. This addition ensures consistency between the two models.

For reference, the commit where block_status was added to flow-go: commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant