fix: api: change return type of getAll() #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the return type of
EntityApiClient.getAll()to be more representative of what it actually returnsDescription
EntityApiClient.getAll()previously returnedPromise<PagedList<T>>, whereTis defined as the type of the entity's ID.It actually returns, at runtime and after the promise is fulfilled etc, a PagedList of entities.
Related Issue
#54
Motivation and Context
To fix a TypeScript type check error encountered if you create a typed ref and then try to assign its value to the awaited value of
entityApiClient.getAll()This is a pretty low priority bug to be honest as at runtime we don't get any issues, but it's just something I noticed