fix event caching #2395
Open
fix event caching #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pbalcer
commented
Nov 28, 2024
•
pbalcer
commented
pbalcer
force-pushed
the
fix-event-pooling
branch
from
a9550cd
to
984fcf6
Compare
pbalcer
force-pushed
the
fix-event-pooling
branch
from
984fcf6
to
90de421
Compare
L0 requires the adapter to use a variety of different events, depending on the specific use case and configuration. Events are also unique for devices. And, because the adapter wants to avoid unnecessarily allocating new events from the driver, this necessities an event caching solution that can separate the different event type and device combinations. When counter-based events were introduced the event caching was not properly expanded to take that event type into consideration, presumably with the assumption that normal and counter based events will never coexist. Unfortunately that is not true for the current adapter implementation. This patch simplifies the event caching logic, ensuring that each unique event type and device combination has its own event cache.
pbalcer
force-pushed
the
fix-event-pooling
branch
from
90de421
to
100c648
Compare
pbalcer
added
v0.10.x
pbalcer
commented
Nov 28, 2024
| @@ -17,6 +17,11 @@ set(UR_TEST_FUZZTESTS ON CACHE BOOL "Run fuzz tests if using clang and UR_DPCXX | |||
| set(gtest_force_shared_crt ON CACHE BOOL "" FORCE) | |||
| set(INSTALL_GTEST OFF) | |||
| FetchContent_MakeAvailable(googletest) | |||
|
|
|||
| set_target_properties(gtest PROPERTIES POSITION_INDEPENDENT_CODE ON) | |||
There was a problem hiding this comment.
I needed these on SLES for some reason. I'll remove them and create a separate PR once CI finishes (I don't want to force push right now to restart everything).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.