RFC for zip_view implementation, for oneDPL C++20 #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akukanov
reviewed
Nov 20, 2024
| ### Key Requirements | ||
| `oneapi::dpl::ranges::zip_view` should have: | ||
| - API compliance with `std::ranges::zip_view` | ||
| - `oneapi::dpl::__internal::tuple` underhood, due to `std::tuple` has issues with swapability and device copyability. |
There was a problem hiding this comment.
Should this be just "oneDPL zip_view should be device copyable"?
Regarding swap: does the standard zip_view work with std::sort? If yes, how does it deal with swapping temporaries?
| which the same API and functionality as `std::ranges::zip_view`. | ||
|
|
||
|
|
||
| ### Key Requirements |
There was a problem hiding this comment.
I think there is more requirements / open questions to think about:
- The necessity to support C++20.
- What about using it with the non-range algorithms via zip_view::iterator?
- How would it correlate with zip_iterator?
- Should/will it work with any "underlying" views/ranges, or there might be restrictions?
- Anything special that distributed ranges would need?
Comment on lines
+21
to
+25
| ### Performance | ||
| Combining `std::ranges::zip_view` with data pipelines and kernel fusion enables developers to write expressive, | ||
| efficient code for processing multiple related datasets. This approach not only simplifies the logic but also | ||
| optimizes performance, making it an essential technique in modern C++ development. Whether you're working with | ||
| simple transformations or complex data processing workflows, zip_view can be a valuable utility. |
There was a problem hiding this comment.
This part seems rather motivational.
Are there any performance-related design considerations and/or requirements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal to implement
zip_viewin oneDPL. A part of the general RFC discussion #1944 about implementing useful C++23 views.