Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend RFC announcement to include discussions #1742

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend RFC announcement to include discussions #1742

wants to merge 2 commits into from

Conversation

timmiesmith
Copy link
Contributor

The PR updates the action that currently announces PR labeled as RFC to the oneDPL Slack channel to include discussions labeled as RFC as well.

@timmiesmith
Copy link
Contributor Author

I'm using https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#discussion to identify the keywords needed.

@danhoeflinger
Copy link
Contributor

It looks like the action checks github.event.pull_request.labels.*.name, for RFC, but is this the same variable we should be checking for discussions as well?
I assume we need a second check or to modify this one to cover github.event.discussion.labels.*.name (guessing the formulation of this).

@akukanov akukanov added the follow through PRs/issues that should be completed/resolved label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhoeflinger danhoeflinger Awaiting requested review from danhoeflinger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
follow through PRs/issues that should be completed/resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmiesmith @danhoeflinger @akukanov