Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU][rls-v3.7] Revert jit::gemm handling for f32 src, f16 fpmath #2496

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[GPU][rls-v3.7] Revert jit::gemm handling for f32 src, f16 fpmath #2496

merged 2 commits into from
Jan 30, 2025

Conversation

kealan-barbieri
Copy link
Contributor

Description

Backport of #2467

@kealan-barbieri kealan-barbieri added platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel backport labels Jan 23, 2025
@kealan-barbieri kealan-barbieri requested a review from a team as a code owner January 23, 2025 23:26
@kealan-barbieri
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_matmul
enable benchdnn_ip

@kealan-barbieri
Copy link
Contributor Author

make test perf-gpu
set primitive=matmul

rjoursler
rjoursler approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@rjoursler rjoursler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think my feedback on #2467 needs backported to this PR. The solutions are effectively close enough that I am fine with just merging this version into v3.7 to avoid extra validation delays.

@kealan-barbieri kealan-barbieri force-pushed the kealanba/disable_f32_f16_fpmath_v3.7 branch from 0ef9d6d to c99d00d Compare January 30, 2025 00:05
@kealan-barbieri
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_matmul
enable benchdnn_ip

@karturov karturov merged commit 494d39a into rls-v3.7 Jan 30, 2025
4 of 5 checks passed
@karturov karturov deleted the kealanba/disable_f32_f16_fpmath_v3.7 branch January 30, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjoursler rjoursler rjoursler approved these changes

@karturov karturov karturov approved these changes

Assignees
No one assigned
Labels
backport platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kealan-barbieri @karturov @rjoursler