-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement e2e tests #2
Conversation
WalkthroughA flurry of updates dances through the codebase! From end-to-end tests to Makefile enhancements, and blockchain validations, the changes bring new workflows, targets, and test scenarios, enriching the project's testing and build processes. Changes
Poem
Note Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (3)
e2e/main_test.go (3)
13-53
: Consider adding comments to explain the purpose of each test block for better readability.
55-112
: Consider adding comments to explain the purpose of each test block for better readability.
114-193
: Consider adding detailed comments, especially around blocklist functionality, to enhance understanding and maintainability.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
e2e/go.mod
is excluded by!**/*.mod
e2e/go.sum
is excluded by!**/*.sum
go.mod
is excluded by!**/*.mod
go.sum
is excluded by!**/*.sum
go.work
is excluded by!**/*.work
go.work.sum
is excluded by!**/*.sum
Files selected for processing (8)
- .github/workflows/e2e-tests.yaml (1 hunks)
- .github/workflows/unit-tests.yaml (2 hunks)
- Makefile (2 hunks)
- chains.yaml (1 hunks)
- e2e/main_test.go (1 hunks)
- e2e/utils.go (1 hunks)
- x/aura/types/blocklist/genesis.go (1 hunks)
- x/aura/types/genesis.go (1 hunks)
Files skipped from review due to trivial changes (1)
- chains.yaml
Additional comments not posted (6)
.github/workflows/unit-tests.yaml (2)
5-7
: Branch filters updated to includemain
and version tags. This is a good practice to ensure that CI processes are triggered only for significant branches.
20-20
: Go version updated to support>=1.21
. Ensure that all dependencies are compatible with this version range.x/aura/types/blocklist/genesis.go (1)
14-17
: Added validation forOwner
field to check if it is not empty before validating the address. This enhances robustness and prevents potential runtime errors.x/aura/types/genesis.go (1)
18-21
: Added validation forOwner
field to check if it is not empty before validating the address, similar to the blocklist module. Good consistency across modules..github/workflows/e2e-tests.yaml (1)
1-90
: Introduced a comprehensive GitHub Actions workflow for end-to-end testing. The workflow is well-organized with separate jobs for building, preparing, and testing. It uses specific GitHub Actions likestrangelove-ventures/heighliner-build-action
andactions/upload-artifact
, and defines necessary environment variables and concurrency settings.Makefile (1)
2-2
: Updated theall
target to includelocal-image
andtest-e2e
. Ensure that these new targets function as expected by running them in different build environments.Verification successful
The
local-image
andtest-e2e
targets are correctly defined in theMakefile
. Thelocal-image
target checks for the presence ofheighliner
and builds an image if found, while thetest-e2e
target runs end-to-end tests using Go.
local-image
target:
- Checks for
heighliner
and builds an image if available.test-e2e
target:
- Runs end-to-end tests using Go.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the functionality of `local-image` and `test-e2e` targets. # Test: Run the `all` target and check outputs. make allLength of output: 82
Script:
#!/bin/bash # Description: Verify the existence of `local-image` and `test-e2e` targets in the Makefile. # Search for the `local-image` target in the Makefile grep -A 5 '^local-image:' Makefile # Search for the `test-e2e` target in the Makefile grep -A 5 '^test-e2e:' MakefileLength of output: 413
@boojamya Could you please look into this Heighliner issue?
The GitHub Action doesn't have access to the repository (because it's private), and I tried to fix this in noble-assets@7df3813, but doesn't seem to do anything 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, ty!
e07f2d9
to
d4df356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look great, very readable!
Closes #1
Summary by CodeRabbit
New Features
Bug Fixes
go-version
in unit tests workflow.Documentation
Tests
e2e
package.