FI-3023: Bump validator to 1.0.59 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehall
changed the title
dehall
changed the title
Jammjammjamm
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the validator to version 1.0.59 which is the most recent as of today. Their version endpoint has changed to return a JSON, just like our validator did, so I updated the configuration checker logic to handle that. Sample version response from https://validator.fhir.org/validator/version :
Note that I also changed the expected version to be the wrapper version (1.0.59) not the core validator version (6.4.4) since that's the version actually specified in docker-compose, and I hope that will be less confusing.
Fortunately this release compared to 1.0.52 doesn't seem to have resulted in any new error messages for our reference server data, so nothing new to add to message filters.