Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

730 feat allow non destructive confirm modals to accept reactnode descriptions #731

Conversation

caseybaggz
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior (required)?

closes #730

What is the new behavior (required)?

  • Updates ConfirmModal show types to be more strict
  • Allows ReactNode for non-destructive descriptions

Other information?

@caseybaggz caseybaggz linked an issue Nov 20, 2024 that may be closed by this pull request
4 tasks
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cerberus-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 4:54pm

@caseybaggz caseybaggz marked this pull request as ready for review November 20, 2024 17:57
@caseybaggz caseybaggz merged commit d1e87c5 into main Nov 20, 2024
7 checks passed
@caseybaggz caseybaggz deleted the 730-feat-allow-non-destructive-confirm-modals-to-accept-reactnode-descriptions branch November 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat?]: allow non-destructive confirm modals to accept ReactNode descriptions
1 participant