Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): make Portal a client component #716

Conversation

caseybaggz
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior (required)?

closes #712

What is the new behavior (required)?

  • Updates Portal to be a client component
  • Adds more detailed JSDOCs

Other information?

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cerberus-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:21pm

@caseybaggz caseybaggz marked this pull request as ready for review November 18, 2024 16:22
@caseybaggz caseybaggz merged commit bd594cf into main Nov 18, 2024
7 checks passed
@caseybaggz caseybaggz deleted the 712-bug-the-portal-component-returning-null-causes-a-hydration-issue-on-next14-and-next15s-first-load branch November 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: the Portal component returning null causes a hydration issue on next14 and next15's first load
1 participant