fix(ci): fix the log file label and run on bigger runner #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmllr
force-pushed
the
chmllr/fix-logs-filename
branch
from
5c7869e to
e77e46e
Compare
ttarsi
approved these changes
Nov 1, 2024
chmllr
commented
Nov 1, 2024
| @@ -45,6 +46,6 @@ jobs: | |||
| uses: actions/upload-artifact@v4 | |||
| if: always() | |||
| with: | |||
| name: failed-logs | |||
| name: docker-logs | |||
There was a problem hiding this comment.
These logs are uploaded on successful runs as well, so the label might be misleading for successful jobs.
chmllr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix of log file and specifying a large instance to run the network join test.
issue: none