WIP: refactor: made function get_partition_info() matching disk label language agnostic #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uage agnostic Signed-off-by: Harry Waschkeit <[email protected]>
|
|
Signed-off-by: Harry Waschkeit <[email protected]>
mlilien
reviewed
Nov 25, 2024
| @@ -393,7 +393,7 @@ fn get_partition_info(image_file: &str, partition: &Partition) -> Result<Partiti | |||
| Partition::boot => 1, | |||
| Partition::rootA => 2, | |||
| p @ (Partition::factory | Partition::cert) => { | |||
| let re = Regex::new(r"Disklabel type: (\D{3})").unwrap(); | |||
| let re = Regex::new(r": (dos|gpt)").unwrap(); | |||
There was a problem hiding this comment.
I suggest to don't use fdisk (we don't know if it is installed, and which version, e.g. busybox and so on).
We should look into crates which read partition tables.
HarryWaschkeit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.