Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and add White Label Installments #492

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Review and add White Label Installments #492

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d062ea
Add WLB installment banks in providers in omise-offsite-installment-m…
aashishgurung Sep 13, 2024
2ab0dce
Refactored /omise-offsite-installment-method.js
aashishgurung Sep 13, 2024
ec3aa80
Move installment_wlb_ktc to a new line.
aashishgurung Sep 13, 2024
6668e7e
Add test for Model/Api/Capabilities
aashishgurung Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Helper/OmiseHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,18 @@ class OmiseHelper extends AbstractHelper
Installment::UOB_ID => Installment::CODE,
Installment::MBB_ID => Installment::CODE,

// offsite installment banking payment
// offsite wlb installment banking payment
Installment::WLB_BAY_ID => Installment::CODE,
Installment::WLB_BBL_ID => Installment::CODE,
Installment::WLB_UOB_ID => Installment::CODE,
Installment::WLB_FIRST_CHOICE_ID => Installment::CODE,
Installment::WLB_KBANK_ID => Installment::CODE,
Installment::WLB_KTC_ID => Installment::CODE,
Installment::WLB_SCB_ID => Installment::CODE,
Installment::WLB_TTB_ID => Installment::CODE,
Installment::WLB_UOB_ID => Installment::CODE,

// offsite mobile banking payment
Mobilebanking::BAY_ID => Mobilebanking::CODE,
Mobilebanking::BBL_ID => Mobilebanking::CODE,
Mobilebanking::KBANK_ID => Mobilebanking::CODE,
Expand Down
2 changes: 1 addition & 1 deletion Model/Api/Capabilities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,6 @@ public function getTokenizationMethods()
*/
public function getInstallmentMinLimit()
{
return $this->capabilities['limits']['installment_amount']['min'];
return $this->capabilities ? $this->capabilities['limits']['installment_amount']['min'] : 0;
}
}
19 changes: 19 additions & 0 deletions Model/Config/Installment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,23 @@ class Installment extends Config
const UOB_ID = "installment_uob";

const MBB_ID = "installment_mbb";

/**
* WLB Installments
*/
const WLB_BAY_ID = "installment_wlb_bay";

const WLB_BBL_ID = "installment_wlb_bbl";

const WLB_FIRST_CHOICE_ID = "installment_wlb_first_choice";

const WLB_KBANK_ID = "installment_wlb_kbank";

const WLB_KTC_ID = "installment_wlb_ktc";

const WLB_SCB_ID = "installment_wlb_scb";

const WLB_TTB_ID = "installment_wlb_ttb";

const WLB_UOB_ID = "installment_wlb_uob";
}
4 changes: 0 additions & 4 deletions Observer/InstallmentDataAssignObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
<?php
namespace Omise\Payment\Observer;

use Magento\Framework\Event\Observer;
use Magento\Payment\Observer\AbstractDataAssignObserver;
use Magento\Quote\Api\Data\PaymentInterface;

class InstallmentDataAssignObserver extends OffsiteDataAssignObserver
{
/**
Expand Down
Loading
Loading