Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installment interest rates #460

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Update installment's interest rate.

2. Description of change

Updated the installment's interest rate of the following banks in view/frontend/web/js/view/payment/method-renderer/omise-offsite-installment-method.js file.

Old rates

Bank Interest rate Decimal form
Krungsri First Choice 1.3 % 0.013
Krungsri 0.8 % 0.008
Krungthai Card 0.8 % 0.008
Bangkok Bank 0.8 % 0.008

New rates

Bank Interest rate Decimal form
Krungsri First Choice 1.16 % 0.0116
Krungsri 0.74 % 0.0074
Krungthai Card 0.74 % 0.0074
Bangkok Bank 0.74 % 0.0074

3. Quality assurance

Configure your Opn account's setting and test the amount displayed for each installment term.

🔧 Environments:

  • Platform version: Magento CE 2.4.5
  • Omise plugin version: Omise-Magento 3.1.2
  • PHP version: 8.1.21

4. Impact of the change

The customer will see an installment amount with the new interest applied.

5. Priority of change

Normal

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aashishgurung aashishgurung merged commit 39a0570 into develop Dec 7, 2023
6 checks passed
@aashishgurung aashishgurung deleted the update_installment_interest_rate branch December 7, 2023 07:58
@aashishgurung aashishgurung changed the title Updated installment interest rates Update installment interest rates Dec 7, 2023
@aashishgurung aashishgurung mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants