Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QR expires count down for promptpay #453

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Add QR expires count down for promptpay #453

merged 6 commits into from
Oct 20, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Oct 18, 2023 •
edited
Loading

1. Objective

Add QR expires count down for promptpay

https://opn-ooo.atlassian.net/browse/MIT-1888

2. Description of change

  • Show QR code expire count down instead of date time.

Screenshot 2023-10-18 at 1 47 37 PM

After Expired

Screenshot 2023-10-19 at 9 16 59 AM

3. Quality assurance

  • Crate payment with promptpay QR and checked count down is correct.
  • And wait for expiration and that should be hidden QR code info after expired.

4. Impact of the change

N/A

5. Priority of change

Normal

@ajzkk ajzkk requested a review from aashishgurung as a code owner October 18, 2023 07:18
@ajzkk ajzkk requested review from danfowler, AnasNaouchi, annatotest and a team October 18, 2023 07:18
nuxzero
nuxzero previously approved these changes Oct 18, 2023
View reviewed changes
danfowler
danfowler previously approved these changes Oct 18, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ajzkk ajzkk merged commit 7aacb20 into develop Oct 20, 2023
6 checks passed
@ajzkk ajzkk mentioned this pull request Oct 24, 2023
Merged
@danfowler danfowler deleted the MIT-1888-promptpay-qr-expires-count-down branch October 25, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishgurung aashishgurung aashishgurung approved these changes

@danfowler danfowler danfowler approved these changes

@AnasNaouchi AnasNaouchi Awaiting requested review from AnasNaouchi

@annatotest annatotest Awaiting requested review from annatotest

@nuxzero nuxzero Awaiting requested review from nuxzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajzkk @danfowler @nuxzero @aashishgurung