Add comments to empty non-optional closures

OmiseSDK/Sources/OmiseSDK.swift

@@ -219,7 +219,9 @@ public class OmiseSDK {
 
 private extension OmiseSDK {
     private func preloadCapabilityAPI() {
-        client.capability { _ in }
+        client.capability { _ in
+            // Preload capability and auto cache it as client.latestLoadedCapability
+        }
     }
 }
 

OmiseSDK/Sources/Views/Components/TextFieldView.swift

@@ -46,9 +46,9 @@ class TextFieldView: UIView {
     }()
 
     var onTextFieldShouldReturn: () -> (Bool) = { return false }
-    var onTextChanged: () -> Void = { }
-    var onBeginEditing: () -> Void = { }
-    var onEndEditing: () -> Void = { }
+    var onTextChanged: () -> Void = { /* Non-optional default empty implementation */ }
+    var onBeginEditing: () -> Void = { /* Non-optional default empty implementation */ }
+    var onEndEditing: () -> Void = { /* Non-optional default empty implementation */ }
 
     // swiftlint:disable attributes
     @ProxyProperty(\TextFieldView.textField.keyboardType) var keyboardType: UIKeyboardType

OmiseSDK/Sources/Views/Components/TextFields/OmiseTextField.swift

@@ -21,7 +21,7 @@ public class OmiseTextField: UITextField {
     }
 
     public var onTextFieldShouldReturn: () -> (Bool) = { return false }
-    public var onValueChanged: () -> Void = { }
+    public var onValueChanged: () -> Void = { /* Non-optional default empty implementation */ }
 
     @IBInspectable var borderWidth: CGFloat {
         get {

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Other Payments/Atome/AtomePaymentFormViewModel.swift

@@ -27,7 +27,7 @@ class AtomePaymentFormViewModel: AtomePaymentFormViewModelProtocol, CountryListV
         }
     }
 
-    var onSelectCountry: (Country) -> Void = { _ in }
+    var onSelectCountry: (Country) -> Void = { _ in /* Non-optional default empty implementation */ }
 
     var countryListViewModel: CountryListViewModelProtocol { return self }
 

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Other Payments/Atome/Base/PaymentFormController.swift

@@ -2,7 +2,7 @@ import Foundation
 import UIKit
 
 class PaymentFormController: UIViewController {
-    var onSubmitButtonTappedClosure: () -> Void = { }
+    var onSubmitButtonTappedClosure: () -> Void = { /* Non-optional default empty implementation */ }
 
     @ProxyProperty(\PaymentFormController.headerTextLabel.text)
     var details: String?

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Other Payments/FPX/FPXPaymentFormController.swift

@@ -133,7 +133,7 @@ class FPXPaymentFormController: UIViewController, PaymentFormUIController {
 
     @IBAction private func submitForm(_ sender: AnyObject) {
         emailValue = emailTextField.text?.trimmingCharacters(in: CharacterSet.whitespaces)
-        delegate?.fpxDidCompleteWith(email: emailValue) {}
+        delegate?.fpxDidCompleteWith(email: emailValue) { /* no action is required */ }
     }
 
     @IBAction private func validateFieldData(_ textField: OmiseTextField) {

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/SelectPaymentController.swift

@@ -4,7 +4,9 @@ class SelectPaymentController: UITableViewController {
 
     let viewModel: SelectPaymentPresentableProtocol
 
-    var customizeCellAtIndexPathClosure: (UITableViewCell, IndexPath) -> Void = { _, _ in }
+    var customizeCellAtIndexPathClosure: (UITableViewCell, IndexPath) -> Void = { _, _ in
+        // Non-optional default empty implementation
+    }
 
     init(viewModel: SelectPaymentPresentableProtocol) {
         self.viewModel = viewModel

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/SelectPaymentPresentableProtocol.swift

@@ -19,5 +19,5 @@ extension SelectPaymentPresentableProtocol {
     var errorMessage: String? { nil }
     var viewShowsCloseButton: Bool { false }
     var viewDisplayLargeTitle: Bool { false }
-    func viewDidTapClose() {}
+    func viewDidTapClose() { /* Default empty implementation */ }
 }

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/ViewModels/SelectDuitNowOBWBankViewModel.swift

@@ -3,7 +3,7 @@ import UIKit
 class SelectDuitNowOBWBankViewModel {
     private weak var delegate: SelectSourcePaymentDelegate?
 
-    private var viewOnDataReloadHandler: () -> Void = { } {
+    private var viewOnDataReloadHandler: () -> Void = { /* Non-optional default empty implementation */ } {
         didSet {
             self.viewOnDataReloadHandler()
         }

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/ViewModels/SelectFPXBankViewModel.swift

@@ -6,7 +6,7 @@ class SelectFPXBankViewModel {
 
     let errorMessage: String?
 
-    private var viewOnDataReloadHandler: () -> Void = { } {
+    private var viewOnDataReloadHandler: () -> Void = { /* Non-optional default empty implementation */ } {
         didSet {
             self.viewOnDataReloadHandler()
         }

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/ViewModels/SelectInstallmentTermsViewModel.swift

@@ -4,7 +4,7 @@ class SelectInstallmentTermsViewModel {
     weak var delegate: SelectSourcePaymentDelegate?
     let sourceType: SourceType
 
-    private var viewOnDataReloadHandler: () -> Void = { } {
+    private var viewOnDataReloadHandler: () -> Void = { /* Non-optional default empty implementation */ } {
         didSet {
             self.viewOnDataReloadHandler()
         }

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/ViewModels/SelectPaymentMethodViewModel.swift

@@ -12,7 +12,7 @@ class SelectPaymentMethodViewModel {
     private let filter: Filter
     private weak var delegate: SelectPaymentMethodDelegate?
 
-    private var viewOnDataReloadHandler: () -> Void = { } {
+    private var viewOnDataReloadHandler: () -> Void = { /* Non-optional default empty implementation */ } {
         didSet {
             self.viewOnDataReloadHandler()
         }

OmiseSDK/Sources/Views/Screens/Choose Payment Methods/Select Payment From Lists/ViewModels/SelectSourceTypePaymentViewModel.swift

@@ -4,7 +4,7 @@ class SelectSourceTypePaymentViewModel {
     private weak var delegate: SelectSourceTypeDelegate?
     private let title: String
 
-    private var viewOnDataReloadHandler: () -> Void = { } {
+    private var viewOnDataReloadHandler: () -> Void = { /* Non-optional default empty implementation */ } {
         didSet {
             self.viewOnDataReloadHandler()
         }

OmiseSDK/Sources/Views/Screens/Credit Card Payment/CCVInfoController.swift

@@ -16,7 +16,7 @@ class CCVInfoController: UIViewController {
         }
     }
 
-    var onCloseTapped: () -> Void = { }
+    var onCloseTapped: () -> Void = { /* Non-optional default empty implementation */ }
 
     override func viewDidLoad() {
         super.viewDidLoad()

OmiseSDK/Sources/Views/Screens/Credit Card Payment/CreditCardPaymentViewModel.swift

@@ -42,7 +42,8 @@ class CreditCardPaymentViewModel: CreditCardPaymentViewModelProtocol, CountryLis
             }
         }
     }
-    var onSelectCountry: (Country) -> Void = { _ in }
+
+    var onSelectCountry: (Country) -> Void = { _ in /* Non-optional default empty implementation */ }
 
     func error(for field: AddressField, validate text: String?) -> String? {
         guard isAddressFieldsVisible else { return nil }