Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade library to API version 2019-05-29. #84

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Conversation

aashishgurung
Copy link
Contributor

Description

Upgrade library to support API version 2019-05-29

More information (if any)

  • Removed the flexibility to change API version because this updates will support only the latest API version 2019-05-29.
  • Updated few fields according to the latest API version.
  • Updated tests.

Documentation (if any)

None for now. We need to update our README to announce the new major version release that supports only the latest API version 2019 and guide users on which library version to use for different API version.

Decision(s)

We removed the ability to set the API version. This change is necessary because the upcoming updates will not be compatible with the older API versions. So, switching API version to an older version is impractical. Instead, we specified the API version directly in the library.

Rollback procedure

@aashishgurung aashishgurung changed the base branch from v2.x to master August 28, 2024 09:31
source.go Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Aug 30, 2024

@aashishgurung aashishgurung merged commit c80050b into master Sep 10, 2024
6 checks passed
@aashishgurung aashishgurung deleted the upgrade_api_v2019 branch September 10, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants