Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to fix example and update to Opn Payments #70

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Update README to fix example and update to Opn Payments #70

merged 4 commits into from
Oct 20, 2023

Conversation

danfowler
Copy link
Contributor

@danfowler danfowler commented Oct 20, 2023 •
edited
Loading

  • Omise → Opn Payments (except for name which I think we need to discuss)
  • Fix example which assumes we're passing in a token struct rather than string

@danfowler danfowler marked this pull request as ready for review October 20, 2023 07:05
muthuswamyopn
muthuswamyopn approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@muthuswamyopn muthuswamyopn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

@danfowler danfowler changed the title Update README Update README to fix example and update to Opn Payments Oct 20, 2023
@danfowler danfowler merged commit d6d9ab4 into master Oct 20, 2023
7 checks passed
@danfowler danfowler deleted the update-example-in-readme branch October 20, 2023 08:13
@aashishgurung aashishgurung mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishgurung aashishgurung aashishgurung approved these changes

@muthuswamyopn muthuswamyopn muthuswamyopn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danfowler @muthuswamyopn @aashishgurung