[MIT-1925] Fix app crash from progress view #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuxzero
requested review from
danfowler,
vault087,
aashishgurung,
ajzkk,
AnasNaouchi and
annatotest
nuxzero
changed the title
ajzkk
approved these changes
Oct 6, 2023
aashishgurung
approved these changes
Oct 6, 2023
danfowler
approved these changes
Oct 6, 2023
nuxzero
merged commit 6700bfe
into
feature/MIT-1760-poc-netcetera-3ds-sdk
5 of 6 checks passed
AnasNaouchi
added a commit
that referenced
this pull request
May 13, 2024
* [MIT-1742] Integrate Netcetera 3DS SDK commit cda4211 Author: Natthawut Haematulin <[email protected]> Date: Wed Aug 30 14:01:41 2023 +0700 feat: integrate Netcetera 3DS SDK feat: send authentication request feat: do challenge if status is challenge feat: display progress view and configure sdk logs feat: add comments feat: handle completio result feat: handle not authenticated status chore: move 3ds config to local properties * [MIT-1788] Refactor authorizing payment (#274) * feat: prepare Authentication request and response * fix: revise authentication request * refactor: create wrapper class to encapsulate ThreeDS2Service class * test: add unit tests to test AuthorizingPaymentViewModel * docs: add comments * refactor: remove AuthenticationResult * test: remove ignore annotations from AuthorizingPaymentActivityTest * feat: adjust error deserializer to deserialize by error type * test: fix mocking viewModel in AuthorizingPaymentActivityTest * chore: update handling exception * refactor: revamp AuthenticationRequestBuilder to builder pattern * chore: remove network log * chore: do not hide progress view when challenge is required * fix: move load local props inside defaultConfig * fix: create local.properties file on github actions * docs: add comments * [MIT-1925] Fix app crash from progress view (#278) * fix: remove hide progress view * test: add UI tests * [MIT-1759] UI cutomization configuration (#277) * feat: revamp UiCustomization config * feat: update sample app * feat: add EXTRA_UI_CUSTOMIZATION parameter and set ui customization to 3DS SDK * feat: add support dark mode * chore: update sample code * docs: add UiCustomization comment docs * test: fix failed test * chore: uncomment code * test: add unit tests * test: run test with Robolectric and add unit tests * Enable webview for legacy payments (#282) * Enable webview for legacy payments * Extract logic to private functions * Remove file * Fallback to web flow in case Netcetera 3DS SDK fails (#286) * fallback to web * Add more fallback cases and tests * Format * Formatting Co-authored-by: Daniel Fowler <[email protected]> --------- Co-authored-by: Daniel Fowler <[email protected]> * Move Netcetera secret params to CI (#288) * Move Netcetera secret params to CI * Update EOF cd.yml * Replace strings with enums (#289) * Replace strings with enums * Pass GITHUB_TOKEN in ci.yml * Add pull_request trigger to ci.yml * Remove GITHUB_TOKEN secret * Remove period * Change timedout => timed out Co-authored-by: Daniel Fowler <[email protected]> * Format array * Renamed Open deep-link failed Co-authored-by: Daniel Fowler <[email protected]> --------- Co-authored-by: Daniel Fowler <[email protected]> * Pass params from merchant to sdk (#287) * Add passing params from merchant app to SDK * Sync kotlin example with java example * Update README.md * Fix and add tests * Add append query params function * Remove old 3ds sdk components (#291) * Update Netcetera SDK and replace deprecated methods (#293) * Update Netcetera and replace license key with api key * Remove NETCETERA_LICENSE_KEY from buildConfig * Remove api key log * Update UiCustomization to remove deprecated code * Remove pkey * Reference UiCustomizationType from Netcetera in omise-sdk * Format Co-authored-by: Daniel Fowler <[email protected]> * switch UiCustomizationType to internal * Fix tests * Cover null/empty case * Update README.md * Sync Java example --------- Co-authored-by: Daniel Fowler <[email protected]> * Sync POC with master (#295) * Bump version to 4.12.0 (#280) * docs: update CHANGELOG.md * chore: bump version to 4.12.0 * Update CHANGELOG.md --------- Co-authored-by: AnasNaouchi <[email protected]> * Replace TrueMoney with TrueMoneyJumpApp where available (#292) * Added true money jump app * Update comment Co-authored-by: Daniel Fowler <[email protected]> * Remove unnecessary comment * Add truemoney_jumpapp key to example app for easier override of capability --------- Co-authored-by: Daniel Fowler <[email protected]> * Bump v4.13.0 (#294) --------- Co-authored-by: Natthawut Haematulin <[email protected]> Co-authored-by: Daniel Fowler <[email protected]> * Lint POC code * Fixed capitalization (#303) (#305) * Update README.md --------- Co-authored-by: muthuswamyopn <[email protected]> * Upgrade targetSDKLevel and compileSDKLevel to 34 (#306) * Use device info from Netcetera (#308) * Use device info from Netcetera * Change parameter to encrypted_device_info * Fix unit tests * Format * Sync POC with master (#310) * Fixed capitalization (#303) * Update README.md * Update README.md --------- Co-authored-by: Anas Naouchi <[email protected]> * Implement wechat_pay source (#307) * Add wechat_pay source * Add proper assets * Format * Format Co-authored-by: Daniel Fowler <[email protected]> --------- Co-authored-by: Daniel Fowler <[email protected]> * Bump v4.14.0 (#309) * Bump v4.14.0 * Update CHANGELOG.md Co-authored-by: Daniel Fowler <[email protected]> --------- Co-authored-by: Daniel Fowler <[email protected]> --------- Co-authored-by: muthuswamyopn <[email protected]> Co-authored-by: Daniel Fowler <[email protected]> * Upgrade Android Gradle Plugin (AGP) 8.2.2 (#311) * Upgrade AGP to 8.2.2 and fix build issues * Resolve android studio warning inspection results * Resolve kotlin migration warnings * Resolve kotlin probable bugs and style warnings * Resolve java warnings * Resolve Groovy warnings * Resolve Gradlew warnings where possible * Resolve Markdown warnings * Resolve XML warnings * Resolve Lint correctness warnings where necessary * Resolve Lint performance warnings where necessary * Resolve Kotlin deprecation * Fix unit tests * Remove non-necessary changes * Format * Fix EContextFormFragment.kt * Remove misc.xml changes * Update java version to 21 * Revert "Update java version to 21" This reverts commit c95d2f4. * Add dependsOn tasks * Add dependsOn tasks to correct task * Fix space Co-authored-by: Daniel Fowler <[email protected]> * Remove not-null assertion operator --------- Co-authored-by: Daniel Fowler <[email protected]> * Add 3ds config endpoint (#316) * Add 3DS config endpoint * Add nullable option * Format * Fix unit tests * Encapsulate encryption functions * Format * Format * Add acs check (#320) * Add acs check * Format * Update 3DS logo (#321) * Update Auth and Config models (#323) * Update Auth and Config models * Format * Remove TODO * Update readme (#324) * Update readme * Update README.md * Update README.md * Update README.md --------- Co-authored-by: muthuswamyopn <[email protected]> * Handle config endpoint error and unavailability (#325) * Handle config endpoint error and unavailability * Format * Move functions to ThreeDSConfigProvider class * Update jsonProperty (#327) * Set ThreeDSRequestorAppURL as optional (#331) * Set ThreeDSRequestorAppURL as optional * Add context to optional param * Merge branch 'master' into feature/MIT-1760-poc-netcetera-3ds-sdk * Format * Fix failing unit test (#333) * Fix failed test * Format * Revert "Set ThreeDSRequestorAppURL as optional (#331)" (#335) This reverts commit f6a9cad. * Remove TODO --------- Co-authored-by: Anas Naouchi <[email protected]> Co-authored-by: AnasNaouchi <[email protected]> Co-authored-by: Daniel Fowler <[email protected]> Co-authored-by: muthuswamyopn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix the app crash when hiding after closing the transaction, so we can remove calling
hideProgress()because when closing the transaction it will also hide the progress view.