Separate menu input from per-player input #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nopey
force-pushed
the
magnus/menukeys
branch
from
e8edd7b to
90bc319
Compare
katajakasa
reviewed
Dec 1, 2024
katajakasa
reviewed
Dec 1, 2024
katajakasa
reviewed
Dec 2, 2024
katajakasa
reviewed
Dec 2, 2024
|
|
||
| // Return success | ||
| return 0; | ||
| } | ||
|
|
||
| int vector_swapdelete_at(vector *vec, unsigned index) { |
There was a problem hiding this comment.
The name feels a bit, but I couldn't come up with anything better. I considered making this the default, but I think we rely on vector keeping the order in most places. Blah.
katajakasa
reviewed
Dec 2, 2024
katajakasa
reviewed
Dec 2, 2024
katajakasa
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Probably better than it was. Might be a good idea to get an okay from @Vagabond too.
Nopey
force-pushed
the
magnus/menukeys
branch
from
017e6d8 to
36d2939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only things that are still controlled by per-player input (controller_poll) are Melee, Vs, and Arena.
Everything else now uses
game_state_menu_poll, a drop-in replacement forcontroller_pollthat lets all detected input devices control the menus.Users are unable to rebind the keyboard menu controls, to avoid complications around textinput, multiple keys performing the same action, and ensuring no single key performs multiple actions.
All detected game controllers/joysticks generate menu input events, even when no player has a joystick bound.
Closes #499
Closes #266
Closes #265