Address review feedback

omf2097 · Dec 2, 2024 · 017e6d8 · 017e6d8
1 parent 6706c6f
commit 017e6d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/controller/controller.c b/src/controller/controller.c
@@ -95,8 +95,9 @@ void controller_cmd(controller *ctrl, int action, ctrl_event **ev) {
     iterator it;
     hook_function **p = 0;
     list_iter_begin(&ctrl->hooks, &it);
-    while((p = iter_next(&it)) != NULL) {
-        ((*p)->fp)((*p)->source, action);
+    while((p = iter_next(&it))) {
+        hook_function hook = **p;
+        (hook.fp)(hook.source, action);
     }
 
     ctrl_action_push(ev, action);

diff --git a/src/controller/joystick.c b/src/controller/joystick.c
@@ -238,7 +238,7 @@ void joystick_menu_poll_all(controller *menu_ctrl, ctrl_event **ev) {
         return;
 
     joystick k;
-    memset(&k, 0, sizeof k);
+    memset(&k, 0, sizeof(k));
     joystick_keys keys;
     internal_joystick_default_keys(&keys);
     k.keys = &keys;