habilitar registro para voluntaries #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-diaz
previously approved these changes
Oct 29, 2024
Juanito98
requested changes
Oct 29, 2024
src/pages/registro.tsx
Outdated
Comment on lines
92
to
94
| const volunteerClosingTime = ofmi?.registrationCloseTime | ||
| ? new Date(ofmi?.registrationCloseTime.getFullYear(), 11, 31).getTime() | ||
| : null; |
There was a problem hiding this comment.
Validamos también el closing time.
Te falta agregar esto en src/lib/validators/ofmi.ts validateOFMIOpenAndCloseTime
Sino, les va a arrojar error cuando lo envíen
There was a problem hiding this comment.
Porque el mess 11 y no el 12? Deberia ser hasta el ultimo segundo del ultimo dia
Juanito98
reviewed
Oct 29, 2024
Co-authored-by: Juan Carlos Sigler Priego <[email protected]>
Juanito98
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.